Upgrade GeoServer, decrease max distance from 1 to 0 #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
try
branch
9 times, most recently
from
9b7c309 to
f96946d
Compare
sbrunner
changed the title
sbrunner
force-pushed
the
try
branch
10 times, most recently
from
0666f85 to
2ad3a98
Compare
sebr72
requested changes
Jan 12, 2024
core/src/main/java/org/mapfish/print/test/util/ImageSimilarity.java
Outdated
Show resolved
Hide resolved
examples/src/test/resources/examples/http_processors/config.yaml
Outdated
Show resolved
Hide resolved
...r_ny_EPSG_3857/expected_output/requestData-multi-layer-openlayers-2-compatible-style-wms.png
Outdated
Show resolved
Hide resolved
examples/src/test/resources/examples/simple/expected_output/requestData-fontawesome.png
Outdated
Show resolved
Hide resolved
sbrunner
force-pushed
the
try
branch
6 times, most recently
from
f26ec7e to
745aac9
Compare
sebr72
approved these changes
Jan 17, 2024
core/src/main/java/org/mapfish/print/test/util/ImageSimilarity.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/test/util/ImageSimilarity.java
Outdated
Show resolved
Hide resolved
- simplify the too big images generation - manage the download error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce pixel perfect generation of pdf to mapfish print
At first, I just wanted to set the tolerance parameter to 0,
then I encountered instability problems with GeoServeur, so I updated it,
the problems weren't solved, so I had to simplify a Shapefile.
I also encountered errors with the image layer, which I made more robust in the event of an image loading error.