Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace owner with recipient (SC-17193) #23

Merged
merged 2 commits into from
Jul 3, 2024
Merged

feat: Replace owner with recipient (SC-17193) #23

merged 2 commits into from
Jul 3, 2024

Conversation

vbidin
Copy link
Contributor

@vbidin vbidin commented Jul 3, 2024

No description provided.

@vbidin vbidin requested review from JGcarv and 0xfarhaan July 3, 2024 09:30
@vbidin vbidin self-assigned this Jul 3, 2024
0xfarhaan
0xfarhaan requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@0xfarhaan 0xfarhaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current diff is great, lets add a test where the msg.sender and recipient are different

@vbidin vbidin requested a review from 0xfarhaan July 3, 2024 12:28
@JGcarv JGcarv merged commit 3d49ab8 into main Jul 3, 2024
2 checks passed
@JGcarv JGcarv deleted the sc-17193-feature-mpl-migration-add-recipient-to-migrator branch July 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfarhaan 0xfarhaan 0xfarhaan approved these changes

@JGcarv JGcarv JGcarv approved these changes

Assignees

@vbidin vbidin

Labels
Priority: High Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbidin @JGcarv @0xfarhaan