Update: making value == 0 a UB in count_trailing_zeros_64

mapleFU · Aug 14, 2024 · c241b49 · c241b49
1 parent 51339e7
commit c241b49
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/hyperloglog.c b/src/hyperloglog.c
@@ -399,11 +399,9 @@ static inline int32_t count_trailing_zeros_64(uint64_t value) {
     return __builtin_ctzll(value);
 #else
     int bitpos = 0;
-    if (value) {
-        while (value & 1 == 0) {
-            value >>= 1;
-            ++bitpos;
-        }
+    while (value & 1 == 0) {
+        value >>= 1;
+        ++bitpos;
     }
     return bitpos;
 #endif