Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine release-related documents in a document folder #246

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Combine release-related documents in a document folder #246

merged 4 commits into from
Aug 18, 2021

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Aug 17, 2021

Combine release-related documents in a document folder.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2021

Bundle size report:

Size Change: 0 B
Total Size Before: 206 kB
Total Size After: 206 kB

Output file Before After Change
maplibre-gl.js 197 kB 197 kB 0 B
maplibre-gl.css 9.46 kB 9.46 kB 0 B
ℹ️ View Details No major changes

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is up-to-date anymore, I vote to simply remove this file...

@HarelM
Copy link
Collaborator

HarelM commented Aug 17, 2021

EDIT: making-a-release.md is not relevant according to the last few releases I made, I think it should be deleted.

@astridx
Copy link
Contributor Author

astridx commented Aug 17, 2021

Should I close the PR? Or should we leave it open as a reminder that the process is no longer up to date?

@HarelM
Copy link
Collaborator

HarelM commented Aug 17, 2021

No, just delete the making a release file as part of this PR, and if you want to move the correct file that's fine too.

@HarelM HarelM merged commit 49bc4ca into maplibre:main Aug 18, 2021
@astridx astridx deleted the developerDoc2 branch September 4, 2021 09:04
wipfli pushed a commit to wipfli/maplibre-gl-js that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants