Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapLibre GL JS to 49bc4ca45 #328

Closed
wants to merge 4 commits into from

Conversation

github-actions[bot]
Copy link

No description provided.

@wipfli
Copy link
Contributor

wipfli commented Jun 14, 2022

Ah, great that this automated pull request made it. It updates the MapLibre GL JS submodule to the last commit on the main branch before typescript, i.e., to maplibre/maplibre-gl-js@49bc4ca. The shaders and the style code in MapLibre GL Native was automatically generated by the update-gl-js.yml action.

We need now some sort of testing. I think it would be best if people from the different platforms could checkout this pull request and see if their apps still build and work as expected. I am happy for any inputs how to test such a GL JS update which changes the shaders and some style code...

@wipfli
Copy link
Contributor

wipfli commented Jun 14, 2022

Hm, since a bot made this pull request, CI does not run. I will do an empty commit...

@wipfli
Copy link
Contributor

wipfli commented Jun 14, 2022

I did two commits now. With #311, CI for the older commit gets cancelled. But now it seems that a bunch of workflows are actually also cancelled for the latest commit...

@wipfli
Copy link
Contributor

wipfli commented Jun 14, 2022

Ah maybe I just have to be more patient...

@wipfli
Copy link
Contributor

wipfli commented Jun 18, 2022

I want to regenerate this pull request with the update-gl-js.yml action with a manual trigger such that CI can run again.

@wipfli wipfli closed this Jun 18, 2022
@wipfli wipfli deleted the update-gl-js-to-49bc4ca45 branch June 18, 2022 07:31
@wipfli
Copy link
Contributor

wipfli commented Jun 18, 2022

See #339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant