-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MapLibre GL JS to 49bc4ca45 #359
Conversation
Not sure why the CI is not running. I think GitHub got confused :( |
OK close/reopen has triggered them. |
I run the render tests on ubuntu with the following commands: git clone --recurse-submodules -j8 https://github.com/maplibre/maplibre-gl-native.git
cd maplibre-gl-native
# checkout pull request
gh pr checkout 359
git submodule update --init --recursive
# build stuff
cmake . -B build -G Ninja -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10
cmake --build build -j $(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null)
# run render test
./build/mbgl-render-test-runner --manifestPath metrics/linux-clang8-release-style.json &> render-test.log
# remove color stuff from log file
sed -i 's/\x1b\[[0-9;]*m//g' render-test.log The result is 30 failing tests. |
The failed tests are:
|
I think CI was not triggered because a workflow cannot trigger another workflow or something like that... The close and reopen seems like a good manual trigger solution. |
Are test references shared between JS and native? |
https://wipfli.github.io/debug-maplibre-gl-native/linux-clang8-release-style.html is the current render test output. |
Yes |
The |
It is actually quite cool that the render tests are shared between JS and native. This means that the libraries render stuff the same way down to the single pixel level... |
As horrible as it seems, I think the easiest now is to take the GL JS submodule where it is pinned in main, and slowly move it forward in the commit history until something breaks... |
Closing this for now. I would like to update the submodule step by step and for that we need render tests in CI. |
CI render tests: #357 |
No description provided.