Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Missing init key for maptiler and update style #74

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

ravenfeld
Copy link
Contributor

It's quite strange that the examples don't work. It doesn't help developers.
Let's start by making sure it doesn't crash any more

#62

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravenfeld
Copy link
Contributor Author

Should I still use WellKnownTileServer and getPredefinedStyle?
Because I don't know much about it as I don't use it on my personal project.

@louwers
Copy link
Collaborator

louwers commented Oct 18, 2024

I would not use them, because we will remove them at some point from MapLibre Native.

I created a TestStyles.kt file for MapLibre Native: https://github.com/maplibre/maplibre-native/blob/main/platform/android/MapLibreAndroidTestApp/src/main/java/org/maplibre/android/testapp/styles/TestStyles.kt

@ravenfeld
Copy link
Contributor Author

enum class OpenFreeMapStyle(val url:String){
    POSITRON(url = "https://tiles.openfreemap.org/styles/positron"),
    BRIGHT(url = "https://tiles.openfreemap.org/styles/bright"),
    LIBERTY(url = "https://tiles.openfreemap.org/styles/liberty")
}

Here's what I suggest. So we use this enum instead of getPredefinedStyle

@louwers
Copy link
Collaborator

louwers commented Oct 18, 2024

I like TestStyles class better, might be that we have to replace OpenFreeMap with something else...

@ravenfeld
Copy link
Contributor Author

@louwers Are you happy with my proposal?

@louwers
Copy link
Collaborator

louwers commented Oct 26, 2024

Yes, thanks!

@louwers louwers merged commit c3184da into maplibre:main Oct 26, 2024
1 check passed
@ravenfeld ravenfeld deleted the fix/crash_style branch October 26, 2024 22:15
@klokan
Copy link
Member

klokan commented Oct 28, 2024

😢

@ravenfeld
Copy link
Contributor Author

@klokan is something wrong?

@louwers
Copy link
Collaborator

louwers commented Oct 28, 2024

@ravenfeld @klokan is the CEO of MapTiler. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants