-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: new mbtiles diff
command
#1068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good luck, a fun little project :) I left a few minor comments, but i'm sure lots will change by the end
mbtiles diff
command
I just did a bit of refactoring to separate Clap args from the internals of the |
@sharkAndshark i merged in the main branch, resolving a few conflicts. Let me know if you need any help with this |
@nyurik Thx!! :D Traveling with family, will be back Monday |
Looks much better, thx! TODO: docs and tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking better and better. For testing, please also add another portion to https://github.com/maplibre/martin/blob/main/tests/test.sh#L456
Something basic like
$MBTILES_BIN diff \
./tests/fixtures/mbtiles/world_cities.mbtiles \
./tests/fixtures/mbtiles/world_cities_modified.mbtiles \
"$TEST_TEMP_DIR/world_cities_diff2.mbtiles" \
2>&1 | tee "$TEST_OUT_DIR/copy_diff2.txt"
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think its ready to go.
Implement
mbtiles diff file_a.mbtiles file_b.mbtiles diff.mbtiles
. This should behave exactly the same asmbtiles copy file_a.mbtiles --diff-with-file file_b.mbtiles diff.mbtiles
.mbtiles diff
as a separate command