Added a test for schema.table.column containing special chars #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just adds a test for the unusual case of a table with quotes, spaces, and dots in their identifiers. Another similar test should be added for functions.
2 tasks
|
@sharkAndshark hi, any concerns with this PR? |
|
I'd love to add a test for function but really busy these days, I will add it hours later |
|
Or maybe merge it first, add function test next PR? |
sharkAndshark
approved these changes
Mar 4, 2024
|
Yeah, lets do another PR for that, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a test for the unusual case of a table with quotes, spaces, and dots in their identifiers. Another similar test should be added for functions.