feat!: DashMap based catalog
#1585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a benchmark of the versions "requesting" tiles (i.e. without the network overhead)
=> it is a significant performance drop, but 60ns to enable updating is likely an okay tradeoff. What do you people think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the internal datastructure to be
Dashmap<..>as suggested in #1179 (review)I thought that the data/configuration/.. split might be more managble in terms of reviwing and shipping this.
Sadly two changes did cascade a bit:
&dyn Source->Box<dyn Source>DashMapdoes not guarantee sorting of keys => I need to manually do soI had some free time and this seemed like a nice issue to progress on, I hope you (@sharkAndshark) don't mind me stealing this part ^^