Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in reference.json concerning text { line-spacing } #124

Closed
sommerluk opened this issue Nov 20, 2016 · 3 comments
Closed

Bug in reference.json concerning text { line-spacing } #124

sommerluk opened this issue Nov 20, 2016 · 3 comments

Comments

@sommerluk
Copy link
Contributor

At https://github.com/mapnik/mapnik/wiki/TextSymbolizer is claimed that line-spacing has the type “double”. And indeed also negative floating point values like “-5.9” seem to work fine and decrease the line hight as expected.

Therefore I guess

mapnik-reference/3.0.6/reference.json

Line 2125 in 77f1902

"type": "unsigned",
has to be fixed to allow the usage of negative floating point values also from CartoCSS.

Cross-reference mapbox/carto#452
This was referenced Nov 20, 2016
Closed
Closed
@sommerluk
Copy link
Contributor Author

sommerluk commented Nov 24, 2016 •
edited
Loading

Also

mapnik-reference/3.0.6/reference.json

Line 1317 in 77f1902

"type": "unsigned",
has to be fixed.

@nebulon42
Copy link
Contributor

Actually duplicate of #56.

@sommerluk
Copy link
Contributor Author

This issue applies to both text-line-spacing and shield-line-spacing.

nebulon42 added a commit to nebulon42/mapnik-reference that referenced this issue Dec 22, 2016
@nebulon42
change shield-line-spacing and text-line-spacing to float, fixes mapn…
74a3a70 
…ik#124 mapnik#56
@nebulon42 nebulon42 mentioned this issue Dec 22, 2016
Merged
nebulon42 added a commit to nebulon42/mapnik-reference that referenced this issue Dec 22, 2016
@nebulon42
change shield-line-spacing and text-line-spacing to float, fixes mapn…
7a104dd 
…ik#124 mapnik#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nebulon42 @sommerluk