-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line pattern "repeat" #153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@talaj Thanks! |
@talaj Hi, is there a chance to make v3.0.22 release and merge this code? |
Hi @kocio-pl, I will try to speed it up. |
So Mapnik 3.0.22 is out. I will try to finish this PR. |
talaj
force-pushed
the
line-pattern-type
branch
from
January 22, 2019 21:23
4b75fa9
to
934dce4
Compare
artemp
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great
Thanks @talaj for doing all the work for implementing the polygon-like patterns! |
This was referenced Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
line-pattern-type
and related options introduced to Mapnik in mapnik/mapnik#3980. The functionality will be part of Mapnik 3.0.22 ideally, once mapnik/mapnik#4004 get merged.