Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line pattern "repeat" #153

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Line pattern "repeat" #153

merged 2 commits into from
Jan 23, 2019

Conversation

talaj
Copy link
Member

@talaj talaj commented Oct 25, 2018

Adds line-pattern-type and related options introduced to Mapnik in mapnik/mapnik#3980. The functionality will be part of Mapnik 3.0.22 ideally, once mapnik/mapnik#4004 get merged.

@sommerluk
Copy link
Contributor

@talaj Thanks!

@kocio-pl
Copy link

kocio-pl commented Jan 3, 2019

@talaj Hi, is there a chance to make v3.0.22 release and merge this code?

@talaj
Copy link
Member Author

talaj commented Jan 3, 2019

Hi @kocio-pl, I will try to speed it up.

@talaj
Copy link
Member Author

talaj commented Jan 22, 2019

So Mapnik 3.0.22 is out. I will try to finish this PR.

@talaj talaj changed the title WIP: Line pattern "repeat" Line pattern "repeat" Jan 22, 2019
@talaj talaj requested a review from artemp January 22, 2019 21:33
Copy link
Member

@artemp artemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great

@artemp artemp merged commit ffd5354 into mapnik:gh-pages Jan 23, 2019
@sommerluk
Copy link
Contributor

Thanks @talaj for doing all the work for implementing the polygon-like patterns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants