Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGC Simple Geometries in Vector Tiles #533

Merged
merged 11 commits into from
Oct 7, 2015
Merged

OGC Simple Geometries in Vector Tiles #533

merged 11 commits into from
Oct 7, 2015

Conversation

flippmoke
Copy link
Member

Added ability to use strictly simple in mapnik vector tiles, bumped to version 0.11.0 of mapnik-vector tiles. Added tests to see if geometry is_simple and is_valid using boost geometry

@springmeyer
Copy link
Member

Two thoughts:

  • Ideally use tile_datasource_pbf for lower memory access to data
  • What about instead of a boolean the function returning stats on # of valid/invalid geometries per layer? That seems a whole lot more useful than just returning early on one invalid geometry.

@flippmoke
Copy link
Member Author

@springmeyer I could return invalid geometries but this was an easy first test, I was more concerned on just identifying problem tiles.

@springmeyer
Copy link
Member

Would also be great to have explanations in the docs for what "simple" and "valid" mean exactly according to boost::geometry.

flippmoke added a commit that referenced this pull request Oct 7, 2015
OGC Simple Geometries in Vector Tiles
@flippmoke flippmoke merged commit 02b2de2 into master Oct 7, 2015
@flippmoke flippmoke deleted the strictly_simple branch October 7, 2015 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants