Add target and threshold setpoints #10
Conversation
bricksrc/setpoint.py
Outdated
| @@ -1,347 +1,261 @@ | |||
| from .namespaces import TAG, BRICK, RDFS, QUDTQK | |||
There was a problem hiding this comment.
@jbkoh After moving setpoints into parameter, I found that QUDTQK wasn't imported. If this remains unchanged, we will need to remove the BRICK.hasQauntity properties
There was a problem hiding this comment.
don't understand what this means and the relevance between this line and hasQuantity
There was a problem hiding this comment.
For example, this was recently added to Parameter. I updated the namespace import to include QUDTQK:
"Humidity_Deadband": {
BRICK.hasQuantity: QUDTQK.RelativeHumidity,
There was a problem hiding this comment.
You can add more imports. My ask was not to modify the import path from from .namespaces to from namespaces
| "subclasses": { | ||
| "Enable_Hot_Water_System_Outside_Air_Temperature_Threshold": { | ||
| "tags": [ | ||
| TAG.Point, |
There was a problem hiding this comment.
All thresholds should have Parameter as a tag if Threshold is a subclass of Parameter.
There was a problem hiding this comment.
I wasn't originally planning on defining Threshold as a subclass of parameter, but see the argument for it. I am proposing we add Threshold as a top level class alongside Setpoint and Parameter
TBD
Classes that are debatably not a Setpoint and possibly need to be moved to Parameter:
Deprecations
Classes to be deprecated:
Additions
Classes being added to Setpoint:
Other topics: