redraw layer when layer.optitons attribute changes #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzhenn
requested changes
Mar 9, 2023
fuzhenn
reviewed
Mar 9, 2023
src/layer/tile/TileLayer.js
Outdated
| * refresh tilelayer | ||
| * @return {Layer} this | ||
| */ | ||
| refresh() { |
There was a problem hiding this comment.
不是很建议增加这个方法，按照之前的开发经验，refresh这个方法名含义比较宽泛，容易让人觉得是让图层刷新重绘，可以随意调用，因此一定会被滥用，造成性能问题。
让用户在需要刷新TileLayer的时候，调用一下refresh里的逻辑就行，我们也可以增加一个示例。
// 刷新TileLayer
layer.clear();
layer.load()
fuzhenn
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1893
fix #1896
fix #1898