Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilelayer support custom loadTileBitMap #1966

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

deyihu
Copy link
Collaborator

@deyihu deyihu commented May 19, 2023

fix #1965

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #1966 (505714e) into master (40c0737) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 505714e differs from pull request most recent head 2f83622. Consider uploading reports for the commit 2f83622 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
- Coverage   84.46%   84.44%   -0.02%     
==========================================
  Files         163      163              
  Lines       17489    17493       +4     
==========================================
  Hits        14772    14772              
- Misses       2717     2721       +4     
Impacted Files Coverage Δ
...enderer/layer/tilelayer/TileLayerCanvasRenderer.js 83.12% <50.00%> (-0.24%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

if (this._tileImageWorkerConn && this.loadTileImage === this.constructor.prototype.loadTileImage) {
tileImage = {};
let tileImage = {};
if (this.loadTileBitMap) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方法名应该改成 loadTileBitmap

@fuzhenn fuzhenn merged commit 0a425d0 into maptalks:master May 19, 2023
@deyihu deyihu deleted the 1965 branch May 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cutom tileload support load imagebitmap
3 participants