fix Rectangle/Ellipse/Sector rotate not work #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
+ Coverage 83.65% 83.70% +0.04%
==========================================
Files 167 167
Lines 18579 18648 +69
==========================================
+ Hits 15542 15609 +67
- Misses 3037 3039 +2 ☔ View full report in Codecov by Sentry. |
deyihu
commented
Nov 23, 2023
| @@ -955,6 +966,65 @@ class Geometry extends JSONAble(Eventable(Handlerable(Class))) { | |||
| return this; | |||
| } | |||
|
|
|||
| _rotatePrjCoordinates(coordinates) { | |||
There was a problem hiding this comment.
为什么旋转prj坐标而不是经纬度坐标？
- Rectangle等比较特殊，其绘制是坐标串，但是输入只有一个坐标点，所以单单旋转一个点是无法达到整体图形旋转的，最终效果变成了平移了 PolygonLayer中Rectangle与Cicrle坐标点z值表现异常，Rectangle rotate函数表现异常 issues#515
- 经纬度不是线型分布的，如果使用经纬度来旋转会导致坐标点相对于旋转中心点的夹角计算不对，故采用投影坐标
fuzhenn
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2129
maptalks/issues#515