Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Control.LayerSwitcher.js #547

Merged
merged 17 commits into from
Nov 24, 2017
Merged

Create Control.LayerSwitcher.js #547

merged 17 commits into from
Nov 24, 2017

Conversation

1dent1ty
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #547 into master will decrease coverage by 0.54%.
The diff coverage is 20.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   88.01%   87.46%   -0.55%     
==========================================
  Files         141      142       +1     
  Lines       11881    11975      +94     
==========================================
+ Hits        10457    10474      +17     
- Misses       1424     1501      +77
Impacted Files Coverage Δ
src/control/Control.LayerSwitcher.js 14.94% <14.94%> (ø)
src/layer/tile/GroupTileLayer.js 88.37% <85.71%> (-6.08%) ⬇️
...enderer/layer/tilelayer/TileLayerCanvasRenderer.js 90.97% <0%> (-0.76%) ⬇️
src/layer/Layer.js 91.01% <0%> (+0.56%) ⬆️
src/ui/Menuable.js 93.75% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b7939...4a61988. Read the comment docs.

I'll add css & image files for layerswitcher control after discussion.
1.Adding baseTitle & overlayTitle options for displaying title of base layers & overlay layers.

2.Adding excludeLayers option to exclude layers displaying in layerswitcher.

3.Adding containerClass option to customize className for layerswitcher.

4.Modifying code of confirming visible value considering GroupTileLayer.
@1dent1ty 1dent1ty changed the title Create Control.Layerswitcher.js Create Control.LayerSwitcher.js Nov 24, 2017
@fuzhenn fuzhenn merged commit 76ddd7f into maptalks:master Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants