Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landuse=winter_sports to landuse #343

Closed
nvkelso opened this issue Oct 26, 2015 · 8 comments
Closed

Add landuse=winter_sports to landuse #343

nvkelso opened this issue Oct 26, 2015 · 8 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Oct 26, 2015

Pairing with: #342 to add ski routes to roads layer, we should mark the extend of the winter_sports areas by adding them to the landuse layer.

@zerebubuth
Copy link
Member

After #430, it looks like this (without most of the labels - I really wasn't able to figure out why they aren't rendering):

Lake Tahoe

Before:
lake-tahoe-z11-before

After:
lake-tahoe-z11-after

@zerebubuth
Copy link
Member

It's worth noting that there are really very few of these (about 45 in North America), so perhaps something we can target with a Targeted Editing post? Pistes without an enclosing winter sports area?

@zerebubuth zerebubuth removed their assignment Dec 8, 2015
@nvkelso
Copy link
Member Author

nvkelso commented Dec 8, 2015

@zerebubuth the new pistes features are in the roads layer, and we already calculate the landuse_kind for that layer, so it should be easy to make a Targeted Editing post highlighting the ones missing the landuse AOI, /cc @IndyHurt. The one thing to watch is making sure the landuse sort is sane (not 0 or 1, and probably above forest/wood) otherwise we won't consistently get that?

@nvkelso
Copy link
Member Author

nvkelso commented Dec 14, 2015

We're missing a sort key in the _landuse_sort_order definition in TileStache's tranform step. Let's set this on the server to 4 (so it's above forest and wood).

@zerebubuth
Copy link
Member

I'm not sure that order=4 is the right way to go. Many winter sports areas have forests within the grounds which quite nicely show the larger pistes. For example, with order=4, the whole ski area looks blank:

heavenly-ski-area-z14-landuse-4

Whereas, with order=2, a whole lot more detail is visible:

heavenly-ski-area-z14-landuse-2

Unfortunately, the ski area itself almost disappears. Perhaps we need an overlap-style processing layer to add landuse_parent_kind so that we can display forests inside ski areas differently? Something to think about for #446.

@zerebubuth zerebubuth removed their assignment Dec 14, 2015
@nvkelso
Copy link
Member Author

nvkelso commented Dec 14, 2015

Good point. In the stylesheet it defaults to 1 and I get mostly what you get for a value of 2. Let's go with 2 as that is in with park (2) and still below forest (3).

I'm filtering "wood" and "forest" in the stylesheet so I get more of the winter_sport landuse area showing up (since it's not obscured) at zooms less than 14. Mostly we need to add the sort this landuse can partake in the road layer intercut.

@nvkelso
Copy link
Member Author

nvkelso commented Dec 15, 2015

Verified sort key.

@nvkelso
Copy link
Member Author

nvkelso commented Dec 17, 2015

@sensescape Candidate for another new icon ski / winter_sport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants