Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add winter sports related POIs #344

Closed
6 tasks
nvkelso opened this issue Oct 26, 2015 · 9 comments
Closed
6 tasks

Add winter sports related POIs #344

nvkelso opened this issue Oct 26, 2015 · 9 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Oct 26, 2015

Pairing with #342 and #343, we should add a few more POIs for winter sports.

  • Sled rental (rental=sled or amenity=sled_rental)
  • Ski rental (rental=ski or amenity=ski_rental)
  • Ski school (amenity=ski_school)
  • Mountain rescue and ski patrol (amenity=mountain_rescue)
  • Bobsled track (sport=bobsled)
  • Ski playgrounds (leisure=ski_playground)

Any others seem interesting? Add them to the list :)

@nvkelso nvkelso added this to the v0.6.0 milestone Nov 6, 2015
@nvkelso nvkelso added the ready label Nov 20, 2015
@zerebubuth zerebubuth added in review and removed ready labels Dec 8, 2015
@zerebubuth zerebubuth self-assigned this Dec 8, 2015
@zerebubuth
Copy link
Member

sport=bobsled doesn't appear to be in the database at all (taginfo), but there are 8 instances of sport=luge, so we can use that instead. The sled rental tags only have a single use apiece, which makes me think they're not well-used. However, there are 1,603 uses of man_made=snow_cannon and 1,485 for man_made=snow_fence.

We're going to have the same problem for rental keys as we had for #423 - since that key isn't in osm2pgsql.style we aren't guaranteed to get all of them in the database. We should get most, though, as rental shops probably have names.

@nvkelso
Copy link
Member Author

nvkelso commented Dec 8, 2015

Luge instead of Bobsled sounds fine. Let's skip the sled rental. Good catch on the snow cannon and snow fence!

File related issue for the rental keys?

@zerebubuth
Copy link
Member

Screenshots for a couple of winter sports POI types:

Ski shop in Big Bear:

Scene file snippet:

                ski-rental-or-shop:
                  filter:
                    any:
                      - kind: [ski, ski_rental]
                      - { kind: sports, sport: skiing }
                  draw: { icons: { sprite: marijuana-dispensary } }

big-bear-z18-after

Ski jumping "racetracks" in Lake Placid

Scene file snippet:

        racetrack:
          filter: { kind: racetrack }
          draw:
            lines:
              interactive: true
              order: 5
              cap: round
              join: round
              color: '#cc3333'
              width: [[13,3px],[15, 4px], [16, 5px], [18, 10m], [19, 15m]]

lake-placid-z17-after

@zerebubuth
Copy link
Member

File related issue for the rental keys?

Good point, filed #433 so that we don't lose this issue.

@nvkelso
Copy link
Member Author

nvkelso commented Dec 11, 2015

NOTE: migration still needs to be sorted out for some rental tags.

@nvkelso nvkelso self-assigned this Dec 14, 2015
@nvkelso
Copy link
Member Author

nvkelso commented Dec 17, 2015

Fixed up the sports_centre landuse AOI color, too, so it's not green on green in this area (can see the entire ski training area polygon now, the pitches, and the runs).

@nvkelso
Copy link
Member Author

nvkelso commented Dec 17, 2015

I've verified a good many of these, going to assume the rest of them are working. If something needs tuning, we'll follow up in the next release.

@nvkelso
Copy link
Member Author

nvkelso commented Dec 17, 2015

@sensescape you could really go wild with new icons here!

'ski'
'ski_rental'
'ski_school'
'snow_cannon'
'athletics', 'running', 'horse_racing', 'bmx',
'disc_golf', 'cycling', 'ski_jumping', 'motor', 'karting',
'obstacle_course', 'equestrian', 'alpine_slide', 'soap_box_derby',
'mud_truck_racing', 'skiing', 'drag_racing', 'archery'

@sensescape
Copy link

oooooh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants