Update production calculations #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P_CaCO3%prod(k) and P_SiO2%prod(k) were not being computed correctly in cases where there were multiple calcifiers and silicifiers, respectively. POP%prod(k) was missing the zoo_graze_poc term, which is non-zero when zooplankton grazes on non-zooplankton. The default CESM configuration only has one calcifier and one silicifier, and the single zooplankton does not graze on itself, so this should not be answer changing when PFT_defaults = "CESM2".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P_CaCO3%prod(k) and P_SiO2%prod(k) were not being computed correctly in cases
where there were multiple calcifiers and silicifiers, respectively. POP%prod(k)
was missing the zoo_graze_poc term, which is non-zero when zooplankton grazes
on non-zooplankton.
The default CESM configuration only has one calcifier and one silicifier, and
the single zooplankton does not graze on itself, so this should not be answer
changing when PFT_defaults = "CESM2".
Fixes #224