Would a Pipenv / pytest contribution be welcome?

[TechnicalPirate]

Hi!

Quick question, as I'm looking at contributing to help resolve this issue : #594

I just started looking at the repo structure, it seems most the libraries used are "out of the box" python modules.

Would there be interest in having a PR contributing a basic pipenv setup so we could use the pytest framework or is the expectation to only work with the standard library?

Cheers

:)

[marcelotduarte]

Hi!
I think the author only wanted to use the standard library. I try to follow that line if possible. But I use importlib-metadata which is not standard on py36 and py37 for example. Even on py38 and py39 the version I use has more features than the default. So yes, if it is beneficial, I accept to use.
I have a CI that tests some of the samples. I'm still building these tests, because I'm trying to test if I can build and run the sample, and I don't use pytest.
In some cases, I test without venv and with venv (python -m venv) and I have a test with pipenv for some cases that I knew would give an error to correct them.
In conclusion, the use of pytest is welcome. Alias, the original author or some contributor started using some type of test
There is an issue about using pytest #747

[marcelotduarte]

In PR #1226 I added a stub for util module, to satisfy IDEs.
In PR #1230 I explicitly put pip install -e . in the development section.

[TechnicalPirate]

Hey mate :)

Thanks for the updates - I had some more time today to poke around more.

I've fixed up the existing tests bar one - PR Here for your review.

I'll be on vacation next week so less able to contribute - In the interim please let me know if you want any changes making to the above PR or my prior one for the gitIgnore / pipenv here

Cheers

:)

[TechnicalPirate]

@marcelotduarte - Hey mate, back from vacations + caught up on production work, available to continue my contributions

( Fix existing tests > switch to pytest > write tests for OSX package structure > refactor OSX packaging code )

Can you let me know how to proceed? I submitted 2 PR's already to get everything in place to start switching to Pytest but i need them reviewing / approving before i can continue ( without creating mammoth PR's at least! )

• Change dep-management : Generate dev-requirements.txt + improve readme for contributors wanting to run tests #1224
• Fix existing tests : Fixes for the existing nose tests.. bar one #1234

Edit: Wanted to move forward with this so prepared a draft pull request where i've already done the conversion to the new framework - you can get it / try it here

Current coverage is 27%

Cheers

:)

[marcelotduarte]

Hi! I'm short on time these days, but I'll try to make time so I don't get in the way of your work progress. I'll answer you in PRs.

[TechnicalPirate]

Heya :)

No worries, very understanding on my end :)

Once we've discussed / moved forward with the current Open PR's my focus will be "write tests for OSX package structure" + the real contribution after that! .... i think we're offset 12 hours from each other IRL anyway so its a bit of a tag-team affair regardless :)

[marcelotduarte]

'll look to investigate + fix these locally but it would be good to confirm if these are passing/failing on other windows machines

Are you using windows?

[TechnicalPirate]

Yes :) but i can also use a Mac - Depending on how far i / we go with this i was going to setup a job on our internal CI as well to run cross-platform tests.

[TechnicalPirate]

After discussion with maintainer on some PR's the outcome of this was

1. We should NOT change package/venv manager - the project will stick with pip and venv
2. We should generate a dev-requirements.txt
3. We can switch testing framework from nose to pytest

I will mark this outcome as the answer to this question - further discussion on the nose > pytest switchover will happen on this PR : #1255