-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hooks: fix #2382 regression / improve tests and docs #2443
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
=======================================
Coverage 79.77% 79.77%
=======================================
Files 27 27
Lines 4089 4089
=======================================
Hits 3262 3262
Misses 827 827 ☔ View full report in Codecov by Sentry. |
Please do a test without freeze_support so you can see the message (before it was in a loop). |
Won't be able to test today unfortunately, Just realized its almost 1am |
be860fe
to
7ac448f
Compare
Works on windows |
testing mac next |
On mac, when commenting out The failing tests are sample1-spawn and sample2-spawn. They fail in expected ways. The passing tests have no output but that may be a config issue on my side (or false passes) |
They fail but do not enter an infinite loop as before, right? |
Correct |
b72ab4b
to
d99f2b9
Compare
Co-authored-by: Nicholas Tindle <nicktindle@outlook.com>
d99f2b9
to
85cb64a
Compare
Closes #2435
Closes #2433
#2376