Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: fix #2382 regression / improve tests and docs #2443

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

marcelotduarte
Copy link
Owner

Closes #2435
Closes #2433
#2376

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.77%. Comparing base (c3b273e) to head (6e80828).
Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2443   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files          27       27           
  Lines        4089     4089           
=======================================
  Hits         3262     3262           
  Misses        827      827           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/src/faq.rst Outdated Show resolved Hide resolved
@marcelotduarte
Copy link
Owner Author

Please do a test without freeze_support so you can see the message (before it was in a loop).

@ntindle
Copy link
Contributor

ntindle commented Jun 7, 2024

Won't be able to test today unfortunately, Just realized its almost 1am

@ntindle
Copy link
Contributor

ntindle commented Jun 10, 2024

Works on windows

@ntindle
Copy link
Contributor

ntindle commented Jun 10, 2024

testing mac next

@ntindle
Copy link
Contributor

ntindle commented Jun 11, 2024

On mac, when commenting out multiprocessing.freeze_support() 5 of the 7 multiprocessing tests still pass
With the freeze_support enabled, all tests pass.

The failing tests are sample1-spawn and sample2-spawn. They fail in expected ways. The passing tests have no output but that may be a config issue on my side (or false passes)

@marcelotduarte
Copy link
Owner Author

The failing tests are sample1-spawn and sample2-spawn. They fail in expected ways.

They fail but do not enter an infinite loop as before, right?

@ntindle
Copy link
Contributor

ntindle commented Jun 11, 2024

Correct

@marcelotduarte marcelotduarte merged commit de7a013 into main Jun 13, 2024
26 checks passed
@marcelotduarte marcelotduarte deleted the multiprocessing branch June 13, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants