Fix TypeError thrown in mockReset/mockClear #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vylpes
pushed a commit
to Vylpes/Droplet
that referenced
this pull request
Sep 14, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [jest-mock-extended](https://github.com/marchaos/jest-mock-extended) | devDependencies | major | [`^2.0.4` -> `^3.0.0`](https://renovatebot.com/diffs/npm/jest-mock-extended/2.0.4/3.0.4) | --- ### Release Notes <details> <summary>marchaos/jest-mock-extended</summary> ### [`v3.0.4`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.4) [Compare Source](marchaos/jest-mock-extended@3.0.3...3.0.4) - Updated jest dependencies - Updated typescript peerDependencies to allow for typescript 5.\* ### [`v3.0.3`](marchaos/jest-mock-extended@3.0.2...3.0.3) [Compare Source](marchaos/jest-mock-extended@3.0.2...3.0.3) ### [`v3.0.2`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.2) [Compare Source](marchaos/jest-mock-extended@3.0.1...3.0.2) Added marchaos/jest-mock-extended#110 ### [`v3.0.1`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.1) [Compare Source](marchaos/jest-mock-extended@3.0.0...3.0.1) Allow overriding calledWithFn - see marchaos/jest-mock-extended#96 ### [`v3.0.0`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.0) [Compare Source](marchaos/jest-mock-extended@3602a65...3.0.0) - Fixed performance issue for marchaos/jest-mock-extended#97. This required a small API change, hence the major version bump. Deep mocking functions with properties is still possible using ```typescript mockDeep({ funcPropSupport: true }); ``` however this comes with a recursive performance cost. We hope to address this in the future. ### [`v2.0.9`](marchaos/jest-mock-extended@c6fdf33...3602a65) [Compare Source](marchaos/jest-mock-extended@c6fdf33...3602a65) ### [`v2.0.8`](marchaos/jest-mock-extended@2.0.7...c6fdf33) [Compare Source](marchaos/jest-mock-extended@2.0.7...c6fdf33) ### [`v2.0.7`](https://github.com/marchaos/jest-mock-extended/releases/tag/2.0.7) [Compare Source](marchaos/jest-mock-extended@2.0.6...2.0.7) ### Fixes - Fix DeepMockProxy type error for objects which are functions and have fields at the same time - marchaos/jest-mock-extended#95 ### [`v2.0.6`](https://github.com/marchaos/jest-mock-extended/releases/tag/2.0.6) [Compare Source](marchaos/jest-mock-extended@2.0.5...2.0.6) Support for Jest 28 ### [`v2.0.5`](https://github.com/marchaos/jest-mock-extended/releases/tag/2.0.5) [Compare Source](marchaos/jest-mock-extended@2.0.4...2.0.5) Fixes: - Explicitly Show DeepMockProxy<T> In Readme Example - marchaos/jest-mock-extended#86 - Fix ESM support by avoiding export default as syntax - marchaos/jest-mock-extended#83 - Fix TypeError thrown in mockReset/mockClear - marchaos/jest-mock-extended#81 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9--> Co-authored-by: Renovate Bot <renovate@vylpes.com> Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/Droplet/pulls/109 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: RenovateBot <renovate@vylpes.com> Co-committed-by: RenovateBot <renovate@vylpes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the bug where TypeError is thrown in
mockReset/mockClearwhen the mock has properties withnullorundefinedvalues.I encounter this bug when using
jest-mock-extendedalong withjest-when(https://github.com/timkindberg/jest-when/blob/master/src/when.js#L204).jest-wheninternally uses__whenMock__property to store the mock setup, and assignundefinedto this once the mock is reset. CallingmockClearormockResetafter that would throw TypeError exception.