[Fix] Better handling of projection Faulted status #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dev-rowbot, I will look at this PR soon. Is there any way to trigger the Faulted state for projection so that I can do some testing? |
|
I was able a way to make the projection go into faulted state and this change seems to work for both faulted-enabled and faulted stopped projections, although ESDB is far from consistent in naming these statuses. This is now released in v0.13.1 |
|
Thank you for merging this @marcinbudny - sorry I took so long to respond. To test I just created a bad projection (invalid syntax). In our environment the error occurred because the projection timed out, it took longer than 250ms to process. Maybe that could be simulated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some real world results, just checking for
Faultedis not good enough then because the UI will show a projection asFaulted (enabled)which is actually some combination of strings.The eventstore docs do allude to this but it does not appear to show all possible states
https://developers.eventstore.com/clients/grpc/projections.html#projection-details
This change will check if the
Statusfield contains theFaultedsub-string. This prevents us getting in to a state where a projection is neitherStarted,Stopped, orFaulted. That is still possible, but missing aFaultedstated is critical and missingInitialis not.