forked from spulec/freezegun
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid
asyncio.sleep()
hanging forever when time is frozen
The following code: async def test(): with freeze_time("2020-01-01"): await asyncio.sleep(0.01) hangs forever since FreezeGun 1.1.0 because 1.1.0 started patching `time.monotonic()` (see spulec#369) which is used internally by `asyncio` event loops to schedule code for execution in the future. This breaks many projects that uses FreezeGun to test asynchronous code. We fix this by changing `freeze_time` to patch asyncio event loop's `time()` method in a way that it uses real monotonic time instead of the frozen one. Note that we couldn't achieve this by adding `asyncio` to `DEFAULT_IGNORE_LIST` in `freezegun/config.py` because any running async code has functions from the `asyncio` module on its stack -- adding `asyncio` to the ignore list would just disable freezing time in any async code. This is why we patch one method of a specific class instead. This change not only fixes `asyncio.sleep()` but also things like `asyncio.get_running_loop().call_later` (for scheduling task execution in the future) which in turn makes things like timeouts work in async code while time is frozen. This may not be desired because some users may expect that execution of events scheduled to happen in the future can be controlled using FreezeGun. However, it's not easy to distinguish between things that users would like to see frozen time and those which should not (like `asyncio.sleep()`) because all of them use the same clock. Therefore, we opt for making all `asyncio` internals not affected by FreezeGun. We also add more tests that verify how FreezeGun interacts with asyncio code, including tests that cover the scenario described in spulec#437 which we aim to fix. Closes spulec#401 Closes spulec#437
- Loading branch information
1 parent
86f69e4
commit d9ca136
Showing
4 changed files
with
92 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters