Use bash-completion@2 on Mac

This is to avoid the bug where
  testprog > out<TAB>
will not split the line on the ">".

Using bash-completion v2 is what the kubernetes documentation says is
required for Mac anyway.

Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>

tests/bash/comp-test-lib.bash

@@ -12,7 +12,10 @@ _completionTests_TEST_FAILED=0
 # Setup bash_completion package
 bashCompletionScript="/usr/share/bash-completion/bash_completion"
 if [ $(uname) = "Darwin" ]; then
-   bashCompletionScript="/usr/local/etc/bash_completion"
+   bashCompletionScript="/usr/local/etc/profile.d/bash_completion.sh"
+   # Trick bash-completion into thinking this is an interactive shell
+   # See the if statement at the beginning of /usr/local/etc/profile.d/bash_completion.sh
+   PS1="%"
 fi
 source ${bashCompletionScript}
 

tests/test-all.sh

@@ -189,7 +189,7 @@ if [ "$(uname)" == "Darwin" ]; then
     make clean && make build
 
     if [ $SHELL_TYPE = bash ]; then
-       if which bash > /dev/null && [ -f /usr/local/etc/bash_completion ]; then
+       if which bash > /dev/null && [ -f /usr/local/etc/profile.d/bash_completion.sh ]; then
           tests/bash/comp-tests.bash
 
           # Test bashCompletionV2
@@ -198,6 +198,7 @@ if [ "$(uname)" == "Darwin" ]; then
        else
           echo
           echo "Bash or bash_completion package not available locally, skipping MacOS"
+          echo "Please note that you must install bash_completion v2 (brew install bash-completion@2)"
        fi
     fi