-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1900494 [wpt PR 46609] - Add checkmark to base-select options, a=…
…testonly Automatic update from web-platform-tests Add checkmark to base-select options This is being discussed in OpenUI here: openui/open-ui#863 The discussion suggested that we should use a unicode checkmark instead of an SVG, so that's what this patch does. It might be better to use ::marker instead of ::before, but we might also end up with something else entirely and I think that reusing ::marker would be harder to implement, so I am using ::before for now. Bug: 1511354 Change-Id: I29c1dfc26208e6fc13cf42782a3d9d6fae2e711c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5578818 Reviewed-by: David Baron <dbaronchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1313329} -- wpt-commits: 56ec66da8735eb2ccbd9be689917b2b1aad6faed wpt-pr: 46609 UltraBlame original commit: aecc64805ed6326a9941b62fdce414097d8abb42
- Loading branch information
Showing
4 changed files
with
221 additions
and
0 deletions.
There are no files selected for viewing
173 changes: 173 additions & 0 deletions
173
...l/semantics/forms/the-select-element/stylable-select/option-computed-style.tentative.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,173 @@ | ||
< | ||
! | ||
DOCTYPE | ||
html | ||
> | ||
< | ||
link | ||
rel | ||
= | ||
author | ||
href | ||
= | ||
" | ||
mailto | ||
: | ||
jarhar | ||
chromium | ||
. | ||
org | ||
" | ||
> | ||
< | ||
link | ||
rel | ||
= | ||
help | ||
href | ||
= | ||
" | ||
https | ||
: | ||
/ | ||
/ | ||
github | ||
. | ||
com | ||
/ | ||
openui | ||
/ | ||
open | ||
- | ||
ui | ||
/ | ||
issues | ||
/ | ||
863 | ||
# | ||
issuecomment | ||
- | ||
1769004174 | ||
" | ||
> | ||
< | ||
script | ||
src | ||
= | ||
" | ||
/ | ||
resources | ||
/ | ||
testharness | ||
. | ||
js | ||
" | ||
> | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
script | ||
src | ||
= | ||
" | ||
/ | ||
resources | ||
/ | ||
testharnessreport | ||
. | ||
js | ||
" | ||
> | ||
< | ||
/ | ||
script | ||
> | ||
< | ||
select | ||
style | ||
= | ||
" | ||
appearance | ||
: | ||
base | ||
- | ||
select | ||
" | ||
> | ||
< | ||
option | ||
> | ||
option | ||
< | ||
/ | ||
option | ||
> | ||
< | ||
/ | ||
select | ||
> | ||
< | ||
script | ||
> | ||
test | ||
( | ||
( | ||
) | ||
= | ||
> | ||
{ | ||
assert_equals | ||
( | ||
getComputedStyle | ||
( | ||
document | ||
. | ||
querySelector | ||
( | ||
' | ||
option | ||
' | ||
) | ||
' | ||
: | ||
: | ||
before | ||
' | ||
) | ||
. | ||
content | ||
" | ||
\ | ||
u2713 | ||
" | ||
/ | ||
" | ||
" | ||
) | ||
; | ||
} | ||
' | ||
appearance | ||
: | ||
base | ||
- | ||
select | ||
options | ||
should | ||
have | ||
a | ||
checkmark | ||
with | ||
empty | ||
alt | ||
text | ||
. | ||
' | ||
) | ||
; | ||
< | ||
/ | ||
script | ||
> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,11 +90,14 @@ | |
0 | ||
class | ||
= | ||
" | ||
stylable | ||
- | ||
select | ||
- | ||
option | ||
selected | ||
" | ||
> | ||
< | ||
span | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,11 +83,14 @@ | |
0 | ||
class | ||
= | ||
" | ||
stylable | ||
- | ||
select | ||
- | ||
option | ||
selected | ||
" | ||
> | ||
one | ||
< | ||
|