Skip to content

Commit

Permalink
Bug 1465794 [wpt PR 11274] - Worker: Change the default credentials o…
Browse files Browse the repository at this point in the history
…ption from 'omit' to 'same-origin', a=testonly

Automatic update from web-platform-testsWorker: Change the default credentials option from 'omit' to 'same-origin'

This is a follow-up for the spec change:
whatwg/html#3656

Note that ES Modules for dedicated workers is still behind the flag and this
change doesn't affect applications in the real world.

Bug: 848247
Change-Id: I25083f3f11f9d13663e16e2f4c137095e9b12b01
Reviewed-on: https://chromium-review.googlesource.com/1080668
Reviewed-by: Matt Falkenhagen <falkenchromium.org>
Commit-Queue: Hiroki Nakagawa <nhirokichromium.org>
Cr-Commit-Position: refs/heads/master{#563465}

--

wpt-commits: 72c7cfed684554c0d65b7a33d413df9ae1c5999f
wpt-pr: 11274

UltraBlame original commit: 8501df66d1b82cd635660d7868271fc02bd2f0fb
  • Loading branch information
marco-c committed Oct 3, 2019
1 parent a358f4f commit 796b6a1
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 84 deletions.
2 changes: 1 addition & 1 deletion testing/web-platform/meta/MANIFEST.json
Original file line number Diff line number Diff line change
Expand Up @@ -4207389,7 +4207389,7 @@ html
:
[
"
1d6a1629f81d26efcd05bf1c7d40011609238f4f
f182ac364e933ce744b18c0ca6e03ae975a883a3
"
"
testharness
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,21 +208,6 @@
=
=
'
omit
'
)
return
'
'
;
if
(
options
.
credentials
=
=
'
same
-
origin
Expand All @@ -238,11 +223,28 @@
include
'
)
{
return
'
COOKIE_VALUE
'
;
}
if
(
options
.
credentials
=
=
'
omit
'
)
return
'
'
;
assert_unreached
(
'
Expand Down Expand Up @@ -271,12 +273,20 @@
given
WorkerOptions
.
async
function
runCredentialsTest
credentials_test
(
options
description
)
{
promise_test
(
async
(
)
=
>
{
const
worker
Expand Down Expand Up @@ -340,20 +350,18 @@
)
;
}
description
)
;
}
/
/
Tests
for
module
scripts
.
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
type
Expand All @@ -362,7 +370,6 @@
module
'
}
)
'
new
Worker
Expand All @@ -374,23 +381,24 @@
credentials
option
should
not
send
behave
as
'
+
'
credentials
=
same
-
origin
and
send
the
credentials
'
)
;
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
credentials
Expand All @@ -404,7 +412,6 @@
module
'
}
)
'
new
Worker
Expand All @@ -422,13 +429,7 @@
'
)
;
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
credentials
Expand All @@ -444,7 +445,6 @@
module
'
}
)
'
new
Worker
Expand All @@ -463,13 +463,7 @@
'
)
;
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
credentials
Expand All @@ -483,7 +477,6 @@
module
'
}
)
'
new
Worker
Expand All @@ -507,13 +500,7 @@
classic
scripts
.
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
type
Expand All @@ -522,7 +509,6 @@
classic
'
}
)
'
new
Worker
Expand Down Expand Up @@ -552,13 +538,7 @@
'
)
;
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
credentials
Expand All @@ -572,7 +552,6 @@
classic
'
}
)
'
new
Worker
Expand Down Expand Up @@ -602,13 +581,7 @@
'
)
;
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
credentials
Expand All @@ -624,7 +597,6 @@
classic
'
}
)
'
new
Worker
Expand Down Expand Up @@ -656,13 +628,7 @@
'
)
;
promise_test
(
(
)
=
>
runCredentialsTest
credentials_test
(
{
credentials
Expand All @@ -676,7 +642,6 @@
classic
'
}
)
'
new
Worker
Expand Down

0 comments on commit 796b6a1

Please sign in to comment.