Bug 1576703 - Update cbindgen. r=boris

This cleans up the pattern of "Use a private dtor so that the helper functions do the right thing" by enabling it everywhere using: mozilla/cbindgen#377 It also caught some uninitialized value issues. I think they're mostly harmless since we zero-initialize our structs: https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/servo/components/style/properties/gecko.mako.rs#632 And since we override the clip rect, which is the other bit of code that was failing to build with this change. Differential Revision: https://phabricator.services.mozilla.com/D43491 UltraBlame original commit: 6c3f50c6f6662291139bc292fb9dd77aa64331ee
marco-c · Oct 4, 2019 · aab5756 · aab5756
1 parent f35d54a
commit aab5756
Show file tree

Hide file tree

Showing 19 changed files with 83 additions and 918 deletions.
diff --git a/build/moz.configure/bindgen.configure b/build/moz.configure/bindgen.configure
@@ -180,7 +180,7 @@ Version
 .
 9
 .
-0
+1
 '
 )
 #

diff --git a/layout/style/FontFace.cpp b/layout/style/FontFace.cpp
@@ -3786,8 +3786,15 @@ GetFontStyle
 )
 const
 {
-StyleComputedFontStyleDescriptor
+auto
 descriptor
+=
+StyleComputedFontStyleDescriptor
+:
+:
+Normal
+(
+)
 ;
 if
 (

diff --git a/layout/style/FontFaceSet.cpp b/layout/style/FontFaceSet.cpp
@@ -1535,8 +1535,15 @@ ErrorResult
 aRv
 )
 {
-StyleComputedFontStyleDescriptor
+auto
 style
+=
+StyleComputedFontStyleDescriptor
+:
+:
+Normal
+(
+)
 ;
 float
 stretch

diff --git a/layout/style/GeckoBindings.cpp b/layout/style/GeckoBindings.cpp
@@ -7130,6 +7130,17 @@ MOZ_ASSERT
 aImage
 )
 ;
+auto
+zero
+=
+StyleNumberOrPercentage
+:
+:
+Number
+(
+0
+)
+;
 aImage
 -
 >
@@ -7143,6 +7154,16 @@ nsStyleImage
 CropRect
 >
 (
+nsStyleImage
+:
+:
+CropRect
+{
+zero
+zero
+zero
+zero
+}
 )
 )
 ;

diff --git a/layout/style/nsStyleStruct.cpp b/layout/style/nsStyleStruct.cpp
@@ -3681,6 +3681,15 @@ Auto
 (
 )
 )
+mImageRegion
+(
+StyleClipRectOrAuto
+:
+:
+Auto
+(
+)
+)
 mMozListReversed
 (
 StyleMozListReversed
@@ -17709,6 +17718,33 @@ mLineClamp
 (
 0
 )
+mRotate
+(
+StyleRotate
+:
+:
+None
+(
+)
+)
+mTranslate
+(
+StyleTranslate
+:
+:
+None
+(
+)
+)
+mScale
+(
+StyleScale
+:
+:
+None
+(
+)
+)
 mBackfaceVisibility
 (
 NS_STYLE_BACKFACE_VISIBILITY_VISIBLE

diff --git a/servo/components/style/values/computed/text.rs b/servo/components/style/values/computed/text.rs
@@ -1464,25 +1464,6 @@ emphasis
 -
 style
 property
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 derive

diff --git a/servo/components/style/values/generics/effects.rs b/servo/components/style/values/generics/effects.rs
@@ -193,25 +193,6 @@ a
 single
 filter
 .
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 cfg_attr

diff --git a/servo/components/style/values/generics/grid.rs b/servo/components/style/values/generics/grid.rs
@@ -1461,25 +1461,6 @@ track
 -
 breadth
 >
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 derive
@@ -1749,25 +1730,6 @@ track
 -
 size
 >
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 derive
@@ -3649,25 +3611,6 @@ track
 -
 repeat
 >
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 derive
@@ -5216,25 +5159,6 @@ template
 -
 columns
 >
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 derive

diff --git a/servo/components/style/values/generics/svg.rs b/servo/components/style/values/generics/svg.rs
@@ -102,22 +102,6 @@ paint
 server
 value
 .
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 derive
@@ -244,25 +228,6 @@ html
 #
 SpecifyingPaint
 >
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 animation
@@ -425,25 +390,6 @@ fallback
 as
 well
 .
-/
-/
-/
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 #
 [
 animation

diff --git a/servo/components/style/values/generics/transform.rs b/servo/components/style/values/generics/transform.rs
@@ -929,22 +929,6 @@ of
 a
 transform
 value
-/
-/
-/
-cbindgen
-:
-derive
--
-tagged
--
-enum
--
-copy
--
-constructor
-=
-true
 pub
 enum
 GenericTransformOperation