(fix) Fix client.register cache lookup #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subject_to _schema_ids maps subject -> schema -> schema_id, but this lookup is treated as a map subject -> subject -> schema_id, and so always misses, resulting in the registering of a new schema.
|
Hi @Naillik1 Thanks. Could you maybe rebase so the checks can run again? I fixed an issue with |
com4
pushed a commit
to com4/python-schema-registry-client
that referenced
this pull request
Aug 13, 2020
subject_to _schema_ids maps subject -> schema -> schema_id, but this lookup is treated as a map subject -> subject -> schema_id, and so always misses, resulting in the registering of a new schema. Co-authored-by: Marcos Schroh <schrohm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SchemaRegistryClient.subject_to _schema_idsis treated as aMapping[subject, Mapping[schema, schema_id]], but the lookup inSchemaRegistryClient.registeris treated as aMapping[subject, Mapping[subject, schema_id]]and so always misses. This results in a cached schema being registered multiple times.