Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requests library usage #70

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

com4
Copy link
Contributor

@com4 com4 commented Aug 13, 2020

  • the requests library is only used to extract username and password from the url. this
    functionality is part of the standard library so use urlparse instead.

Fixes: #69

com4 added 2 commits August 13, 2020 09:32
- the requests library is only used to extract username and password from the url. this
  functionality is part of the standard library so use `urlparse` instead.

Fixes: marcosschroh#69
@marcosschroh
Copy link
Owner

Thanks @com4 !! 👍

@marcosschroh marcosschroh merged commit 87fb4e0 into marcosschroh:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing requests library in install_requires
2 participants