Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make supplier entity extendable #71

Merged
merged 4 commits into from
May 23, 2023

Conversation

Janvdv
Copy link
Contributor

@Janvdv Janvdv commented Apr 27, 2023

Make supplier entity extendable

@24198 24198 self-assigned this May 3, 2023
@24198
Copy link
Contributor

24198 commented May 3, 2023

Hi @janvdv96,

Thanks for your contribution, we will look at it shortly!

Kind Regards,

Jaimy

@24198
Copy link
Contributor

24198 commented May 17, 2023

Hi @janvdv96,

We've been looking at the contribution and in general it all looks OK. However we did find some additions we would like to see before merging this PR. Currently only adding the code to extend the Supplier is not enough, we would like to see the additions that the Supplier can be updated with fields that have been added to the entity. These additions are mainly in the create/update and view pages of the Supplier.

If you can add these additions, that would be great.

Kind Regards,

Jaimy

@Janvdv
Copy link
Contributor Author

Janvdv commented May 22, 2023

Hi @24198

I've updated the PR with the requested changes. Let me know if this are all the changes you required.

@24198
Copy link
Contributor

24198 commented May 23, 2023

Hi @janvdv96,

We've made a few minor tweaks, but the gist of the views is good! Thanks!
We're currently in the process of merging the changes. Thanks again for your contribution.

Kind Regards,

Jaimy

@24198 24198 merged commit c282ce2 into marellocommerce:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants