Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for RN 0.76 #224

Merged
merged 12 commits into from
Nov 7, 2024
Merged

fix: add support for RN 0.76 #224

merged 12 commits into from
Nov 7, 2024

Conversation

hannojg
Copy link
Member

@hannojg hannojg commented Nov 6, 2024

  • Upgrades the example app to RN 0.76
  • Adds a fix for android's CMakeLists to properly compile on RN 0.76
  • Fixes the eslint setup to work with prettier

All tests on iOS and android are successful!

@hannojg hannojg requested a review from mrousavy November 6, 2024 13:37
@hannojg
Copy link
Member Author

hannojg commented Nov 6, 2024

CI still failing, hold on

All fixed, good to go

@hannojg hannojg linked an issue Nov 7, 2024 that may be closed by this pull request
* fix(ios): fix install problems on new arch

* compile example app for new arch
Copy link
Member

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mrousavy mrousavy merged commit 6918abd into main Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed
2 participants