Stop constant relink after cmake #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously library relinks after every CMake run, even when nothing changes, forcing all downstream project libraries to relink as well.
|
Sorry, I based this patch on 'master' which I now see is dead. Does general new development like these cmake fixes belong on '3.3' perhaps or elsewhere? |
|
default branch is 3.3 - master is not in use anymore and will be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior CMake logic wrote the .def file whenever CMake was run. This forced the next build to relink the library, even when nothing changed, which forced all downstream libraries to relink.
This change simplifies the CMake logic and only writes the .def file when its contents change.