-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: add OverlayProvider just once with the MarigoldProvider #1231
Conversation
We no longer use tsdx to run our tests, since it wasn't update over 8 months ...
🦋 Changeset detectedLatest commit: 4179314 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ix-overlay-provider
…/marigold into fix-overlay-provider
…/marigold into fix-overlay-provider
…ix-overlay-provider
@ti10le It's fine not to have a sheet test for this. Just test if cascading marigold providers works :) |
Yes we already have this test, also we have the test: OverlayProvider is present |
There is still commented out code. |
But this ist from the GlobalStyles PR not from this 🙈 We can also wait until the GlobalStyles is ready 🤷🏽♂️ |
Maaaaaybe that should be fixed first then? 🤪 |
will be fixed in #1395 |
closes #1195