Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add OverlayProvider just once with the MarigoldProvider #1231

Closed
wants to merge 27 commits into from

Conversation

ti10le
Copy link
Contributor

@ti10le ti10le commented Aug 24, 2021

closes #1195

@ti10le ti10le added the type:bug Something isn't working label Aug 24, 2021
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2021

🦋 Changeset detected

Latest commit: 4179314

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@marigold/components Patch
docs Patch
@marigold/icons Patch
@marigold/theme-b2b Patch
@marigold/theme-unicorn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Aug 24, 2021
@coveralls
Copy link

coveralls commented Aug 24, 2021

Coverage Status

Coverage decreased (-0.2%) to 99.796% when pulling 4179314 on fix-overlay-provider into cf9b99c on main.

@sebald
Copy link
Member

sebald commented Sep 9, 2021

@ti10le It's fine not to have a sheet test for this. Just test if cascading marigold providers works :)

@ti10le
Copy link
Contributor Author

ti10le commented Sep 10, 2021

@ti10le It's fine not to have a sheet test for this. Just test if cascading marigold providers works :)

Yes we already have this test, also we have the test: OverlayProvider is present
I think then its ready for final review :)

@sebald
Copy link
Member

sebald commented Sep 10, 2021

There is still commented out code.

@ti10le
Copy link
Contributor Author

ti10le commented Sep 10, 2021

There is still commented out code.

But this ist from the GlobalStyles PR not from this 🙈 We can also wait until the GlobalStyles is ready 🤷🏽‍♂️

@sebald
Copy link
Member

sebald commented Sep 10, 2021

There is still commented out code.

But this ist from the GlobalStyles PR not from this 🙈 We can also wait until the GlobalStyles is ready 🤷🏽‍♂️

Maaaaaybe that should be fixed first then? 🤪

@ti10le ti10le marked this pull request as draft October 4, 2021 10:01
@ti10le
Copy link
Contributor Author

ti10le commented Nov 12, 2021

will be fixed in #1395

@ti10le ti10le closed this Nov 12, 2021
@sebald sebald deleted the fix-overlay-provider branch January 27, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverlayProvider ist added multiple times with the MarigoldProvider
4 participants