Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor <Label> #1914

Merged
merged 1 commit into from
Mar 25, 2022
Merged

feat: Refactor <Label> #1914

merged 1 commit into from
Mar 25, 2022

Conversation

sebald
Copy link
Member

@sebald sebald commented Mar 25, 2022

  • no variants anymore
  • no disabled (not possible anyway)
  • improve a11y

Ref #1889

@sebald
feat: Refactor <Label>
7092a2a 
- no variants anymore
- no disabled (not possible anyway)
- improve a11y

Ref #1889
@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2022

⚠️ No Changeset found

Latest commit: 7092a2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Mar 25, 2022
@sebald
Copy link
Member Author

sebald commented Mar 25, 2022

No changeset since it is not publicly available yet.

@sebald sebald mentioned this pull request Mar 25, 2022
Closed
19 tasks
ti10le
ti10le approved these changes Mar 25, 2022
View reviewed changes
packages/components/src/Field-Next/Label.tsx
@@ -0,0 +1,51 @@
// TODO: But this back into the root, when we realease all the new fields!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Put
*release
😀

packages/components/src/Field-Next/Label.tsx
* aria-required is set on the field and will already be announced,
* so we don't need to add it here.
*/}
{required && <Required role="img" size={16} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for m information: why role img?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://lmgtfy.app/?q=role+img 🤪

@sebald sebald merged commit 762122a into main Mar 25, 2022
@sebald sebald deleted the redo-label branch March 25, 2022 17:13
@ti10le
Copy link
Contributor

ti10le commented Mar 26, 2022

@sebald questions hard ignored 😂

@sebald
Copy link
Member Author

sebald commented Mar 26, 2022

@ti10le don't mark it as approved 😝

@ti10le
Copy link
Contributor

ti10le commented Mar 26, 2022

That was intentional, because it can be gemerged, just thought I still get an answer 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti10le ti10le ti10le approved these changes

Assignees
No one assigned
Labels
type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebald @ti10le