Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refa: <Dialog> #2053

Merged
merged 27 commits into from
May 6, 2022
Merged

refa: <Dialog> #2053

merged 27 commits into from
May 6, 2022

Conversation

sebald
Copy link
Member

@sebald sebald commented May 6, 2022

  • fully accessible
  • uses trigger pattern
  • supports children as function

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 60bc1b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@marigold/docs Major
@marigold/components Major
@marigold/theme-b2b Major
@marigold/theme-core Major
@marigold/theme-unicorn Major
@marigold/storybook-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sebald added 2 commits May 6, 2022 09:38
@sebald
fix linting
bd1c25e
@sebald
Merge branch 'main' into refa-dialog
97da43c 
* main:
  refa: Remove <ValidationMessage> (#2052)
  fix(deps): update dependency @types/node to v16.11.33 (#2051)
  fix(deps): update dependency @theme-ui/css to v0.14.5 (#2050)
@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels May 6, 2022
@sebald sebald mentioned this pull request May 6, 2022
Closed
23 tasks
@sarahgm sarahgm merged commit 759abe9 into main May 6, 2022
@sarahgm sarahgm deleted the refa-dialog branch May 6, 2022 09:02
sebald added a commit that referenced this pull request May 6, 2022
@sebald
Merge branch 'main' into number-field
c729d60 
* main:
  refa: <Dialog> (#2053)
  refa: Move <Label> and <HelpText> to components root (#2054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahgm sarahgm sarahgm approved these changes

Assignees
No one assigned
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebald @sarahgm