onDomRefresh should only trigger if the view.el is actually in the DOM #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cobbweb the memory issue is not that big of an issue, since the tests are not perf dependent. Also since the testing env gets thrown out after tests I am not that worried about refactoring old tests |
|
👍 |
samccone
added a commit
that referenced
this pull request
Jan 13, 2014
onDomRefresh should only trigger if the view.el is actually in the DOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So like 10 months later, I've finally got around to fixing this. :)
onDomRefreshnever actually checked if the view.el was in the DOM, but just assumed it was based on events that had fired on the view (showandrender).This PR does an additional check in
onDomRefreshagainst the DOM so we can guarantee it really is in the DOM.FYI
document.documentElementanddocument.documentElement.contains(x)should be safe to use.I added a call to
view.remove()so we didn't clog the page up with elements. Looks like there's lots of memory leaks in the tests... do we care about this? I always remove any views I created in my own tests.Fixed #748 and fixes #479 and #505.