Skip to content

Commit

Permalink
Fix some deprecations from valueof PR (Azure#29126)
Browse files Browse the repository at this point in the history
  • Loading branch information
timotheeguerin authored and markcowl committed Jun 7, 2024
1 parent 35c2675 commit 39a3bda
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions specification/ai/OpenAI.Assistants/assistants/models.tsp
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ model Assistant {
instructions: string | null;

@doc("The collection of tools enabled for the assistant.")
tools: ToolDefinition[] = [];
tools: ToolDefinition[] = #[];

/**
* A set of resources that are used by the assistant's tools. The resources are specific to the type of tool. For example, the `code_interpreter`
Expand Down Expand Up @@ -103,7 +103,7 @@ model AssistantCreationOptions {

#suppress "@azure-tools/typespec-azure-core/no-nullable" "OpenAI uses explicit nullability, distinct from optionality"
@doc("The collection of tools to enable for the new assistant.")
tools?: ToolDefinition[] = [];
tools?: ToolDefinition[] = #[];

/**
* A set of resources that are used by the assistant's tools. The resources are specific to the type of tool. For example, the `code_interpreter`
Expand Down Expand Up @@ -169,7 +169,7 @@ model UpdateAssistantOptions {
instructions?: string | null;

@doc("The modified collection of tools to enable for the assistant.")
tools?: ToolDefinition[] = [];
tools?: ToolDefinition[] = #[];

/**
* A set of resources that are used by the assistant's tools. The resources are specific to the type of tool. For example,
Expand Down
2 changes: 1 addition & 1 deletion specification/ai/OpenAI.Assistants/runs/models.tsp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ model ThreadRun {
instructions: string;

@doc("The overridden enabled tools used for this assistant thread run.")
tools: ToolDefinition[] = [];
tools: ToolDefinition[] = #[];

@encodedName("application/json", "created_at")
@encode(DateTimeKnownEncoding.unixTimestamp, int32)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ model ScoringRuleOptions {
batchSize?: int32 = 20;

@doc("List of extra parameters from a job that will be sent as part of the payload to scoring rule. If not set, a job's labels (sent in the payload as `job`) and a job's worker selectors (sent in the payload as `selectors`) are added to the payload of the scoring rule by default. Note: Worker labels are always sent with scoring payload.")
scoringParameters?: ScoringRuleParameterSelector[] = [
scoringParameters?: ScoringRuleParameterSelector[] = #[
ScoringRuleParameterSelector.jobLabels,
ScoringRuleParameterSelector.workerSelectors
];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ model CertManagerIssuerRef {
@doc("SANs for certificate.")
model SanForCert {
@doc("DNS SANs.")
dns: string[] = [];
dns: string[] = #[];

@doc("IP address SANs.")
ip: string[] = [];
ip: string[] = #[];
}

@doc("Mqtt Protocol types")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ model PrincipalDefinition {
#suppress "@azure-tools/typespec-azure-resource-manager/arm-no-record" "existing API"
@doc("A list of key-value pairs that match the attributes of the clients. The attributes are case-sensitive and must match the attributes provided by the clients during authentication.")
@OpenAPI.extension("x-ms-identifiers", [])
attributes?: Record<string>[] = [];
attributes?: Record<string>[] = #[];

@doc("A list of client IDs that match the clients. The client IDs are case-sensitive and must match the client IDs provided by the clients during connection.")
clientids?: string[];
Expand Down

0 comments on commit 39a3bda

Please sign in to comment.