Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify and commit as part of PR merge to master #1119

Closed
2 tasks
joshbruce opened this issue Mar 4, 2018 · 4 comments
Closed
2 tasks

Minify and commit as part of PR merge to master #1119

joshbruce opened this issue Mar 4, 2018 · 4 comments

Comments

@joshbruce
Copy link
Member

joshbruce commented Mar 4, 2018

Marked version: 0.3.17

Proposal type: project operations

What pain point are you perceiving?

No real point, just an interesting idea to ponder.

What solution are you suggesting?

  • We could also do a minify stage that would minify and commit after every master branch commit
  • Update the RELEASING docs.
@styfle
Copy link
Member

styfle commented Mar 4, 2018

I’m not convinced this is necessary.
Although we say master should always be releasable, that’s doesnt mean it is always contains a release. The tags are where you can find the release.

Adding minification for each commit will likely lead to merge conflicts for every PR.

@joshbruce
Copy link
Member Author

Having said that, I don't think we're going for a full release here. More like making sure min is always up to date, maybe??

When we merge into master - and there's a code change - and someone uses master directly...not the NPM package or a release build...would they have to minify themselves?

@UziTech
Copy link
Member

UziTech commented Mar 4, 2018

Ya the idea would be to just automatically commit and build marked.min.js so it would always be synced with marked.js.

There would still have to be a manual release

@joshbruce
Copy link
Member Author

Believe this is covered by the preversion script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants