-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis build stages #1113
travis build stages #1113
Conversation
I really like, and am assuming here, that lint comes last; so, we get the really really important sorted first, yeah? |
jobs: | ||
include: | ||
- stage: spec tests 👩🏽💻 | ||
node_js: v0.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this ran properly but why is the first node_js
line missing the -
hyphen prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is the same as json:
[
{
"stage": "spec tests 👩🏽💻",
"node_js": "v0.10"
},
{
"node_js": "v4"
}
]
the hyphen is the start of an array item.
@joshbruce The jobs in each stage run in parallel but each stage runs in series so it will only run Lint if all Test jobs pass. I was thinking it would be good to add stages for unit and integration tests after they are added. We could also do a minify stage that would minify and commit after every master branch commit |
Could be a good thing. If we do that, we should make a note to update the RELEASING docs. |
* add travis build stages * add emoji
* add travis build stages * add emoji
@UziTech ^^ |
this ☝️ should be on #1132 |
* add travis build stages * add emoji
Marked version: 76d75e1
Description
Adds build stages to travis-ci to make it easier to see what failed.
Contributor
Committer
In most cases, this should be a different person than the contributor.