Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis build stages #1113

Merged
merged 2 commits into from
Mar 4, 2018
Merged

travis build stages #1113

merged 2 commits into from
Mar 4, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 3, 2018

Marked version: 76d75e1

Description

Adds build stages to travis-ci to make it easier to see what failed.

image

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@joshbruce
Copy link
Member

I really like, and am assuming here, that lint comes last; so, we get the really really important sorted first, yeah?

jobs:
include:
- stage: spec tests 👩🏽‍💻
node_js: v0.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this ran properly but why is the first node_js line missing the - hyphen prefix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is the same as json:

[
      {
        "stage": "spec tests 👩🏽‍💻",
        "node_js": "v0.10"
      },
      {
        "node_js": "v4"
      }
]

the hyphen is the start of an array item.

@UziTech
Copy link
Member Author

UziTech commented Mar 4, 2018

@joshbruce The jobs in each stage run in parallel but each stage runs in series so it will only run Lint if all Test jobs pass.

I was thinking it would be good to add stages for unit and integration tests after they are added.

We could also do a minify stage that would minify and commit after every master branch commit

@joshbruce
Copy link
Member

We could also do a minify stage that would minify and commit after every master branch commit

Could be a good thing. If we do that, we should make a note to update the RELEASING docs.

@joshbruce
Copy link
Member

#1119

@styfle styfle merged commit 5768180 into markedjs:master Mar 4, 2018
davisjam pushed a commit to davisjam/marked that referenced this pull request Mar 4, 2018
* add travis build stages

* add emoji
@UziTech UziTech deleted the build-stages branch March 4, 2018 22:04
Feder1co5oave pushed a commit to Feder1co5oave/marktex that referenced this pull request Mar 6, 2018
* add travis build stages

* add emoji
@joshbruce
Copy link
Member

@joshbruce
Copy link
Member

@UziTech ^^

@UziTech
Copy link
Member Author

UziTech commented Apr 12, 2018

this ☝️ should be on #1132

zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
* add travis build stages

* add emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants