-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*"Yo"* not outputted correctly #1358
Comments
Hi Jonas, thanks for the bug report! This is indeed a bug in 0.5.1 and also in the latest code on master. Would you like to submit a PR to fix this? |
Started to look at this and found a couple more failing cases
Fixing this is seems like a fairly invasive change as it requires lookahead for square bracket and angle bracket ie to make sure Implementing lookahead seems like it would have a performance impact? Any ideas on how you would recommend approaching this? |
/cc @davisjam |
This was introduced in 0ba2522 |
It's been more than a year, and this is still an issue (as reported in docsifyjs/docsify#976 and docsifyjs/docsify#787). Is anyone fixing it? Please prioritise it 🙏 |
@dialex if you want to submit a PR I would be happy to review it 😁 |
I would if I could, I don't know enough of JS or MarkedJS to be of any help. Workaround: use |
This was fixed in #1686 released in v1.1.1 |
Describe the bug
Emphasize not working when text contains double quotes
To Reproduce
Steps to reproduce the behavior:
marked demo
commonmark demo
The text was updated successfully, but these errors were encountered: