Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size constraints and ability to volunteer to AUTHORS #1117

Merged
merged 2 commits into from
Mar 4, 2018
Merged

Add size constraints and ability to volunteer to AUTHORS #1117

merged 2 commits into from
Mar 4, 2018

Conversation

joshbruce
Copy link
Member

Marked version: 0.3.17

Description

This PR:

  • Adds limits to each contributor type size starting with committer.
  • Makes explicit the concept of volunteering for a change in status to become more engaged.

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@joshbruce joshbruce requested review from UziTech, styfle and davisjam March 3, 2018 19:20
davisjam
davisjam approved these changes Mar 4, 2018
View reviewed changes
Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Some wording tweaks but glad to see this kind of thing getting written down.

@joshbruce joshbruce merged commit 61505c3 into markedjs:master Mar 4, 2018
@joshbruce joshbruce deleted the update-authors branch March 4, 2018 02:15
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@joshbruce
Merge pull request markedjs#1117 from joshbruce/update-authors
b7d77c0 
 Add size constraints and ability to volunteer to AUTHORS
@ekmixon ekmixon mentioned this pull request Jul 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisjam davisjam davisjam approved these changes

@styfle styfle styfle approved these changes

@UziTech UziTech UziTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshbruce @UziTech @styfle @davisjam