-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Jasmine 3.1.0 #1121
[WIP] Jasmine 3.1.0 #1121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my area of expertise; so, mainly just looked at the sample tests. Are we planning to convert all tests to Jasmine (even the MD + HTML ones)...or is that what spec-test is all about? (Just want to make sure I know way forward for #1104.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice start.
Certainly all the things tested by the MD-HTML tests should appear in "unit test"-like form. The existing MD-HTML tests are good integration/whatever-you-call-it tests. |
Ah, I think I may have been slightly hasty in merging this. I think having the new Jasmine infrastructure in place is good so that more than just @UziTech can contribute. However, is Travis configured to run both the old tests and the new tests during the interim? I'm not familiar with Travis configurations so I can't tell. |
[WIP] Jasmine 3.1.0
Marked version: latest
Description
Adds Jasmine for unit and integration testing
TODO:
Fixes #1103
Contributor
Committer
In most cases, this should be a different person than the contributor.