Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Jasmine 3.1.0 #1121

Merged
merged 5 commits into from
Mar 4, 2018
Merged

[WIP] Jasmine 3.1.0 #1121

merged 5 commits into from
Mar 4, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 4, 2018

Marked version: latest

Description

Adds Jasmine for unit and integration testing

TODO:

  • Actually write unit and integration tests
  • Any other types of test?
  • Document new test types?
  • code coverage?
  • Use jasmine to show errors with spec tests instead of custom test harness.
  • Add Unit and Integration build stages on travis

Fixes #1103

Contributor

  • Test(s) exist to ensure functionality and minimize regression
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech requested review from styfle, joshbruce and davisjam March 4, 2018 07:06
Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my area of expertise; so, mainly just looked at the sample tests. Are we planning to convert all tests to Jasmine (even the MD + HTML ones)...or is that what spec-test is all about? (Just want to make sure I know way forward for #1104.)

Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice start.

@davisjam
Copy link
Contributor

davisjam commented Mar 4, 2018

Are we planning to convert all tests to Jasmine (even the MD + HTML ones)

Certainly all the things tested by the MD-HTML tests should appear in "unit test"-like form. The existing MD-HTML tests are good integration/whatever-you-call-it tests.

@davisjam davisjam merged commit 214468b into markedjs:master Mar 4, 2018
@davisjam
Copy link
Contributor

davisjam commented Mar 4, 2018

Ah, I think I may have been slightly hasty in merging this.

I think having the new Jasmine infrastructure in place is good so that more than just @UziTech can contribute.

However, is Travis configured to run both the old tests and the new tests during the interim? I'm not familiar with Travis configurations so I can't tell.

@UziTech UziTech deleted the jasmine branch March 4, 2018 22:04
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants