-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempting CM 331-338 #1124
Attempting CM 331-338 #1124
Conversation
Given the prevalence of Markdown parsers now, I can't imagine this test suite problem isn't already solved. I don't know about you, but copy-paste 50,000 times seems...yeah... If one doesn't already exist, maybe we should just create a repo with a fillable test suite for the MD + HTML...or even Jasmine, if possible. Pseudo:
Make that available to the other JS markdown parsers as a package to test their stuff too...?? Anyway, definitely pausing on this one for now. Tagging Dr. DevOps for thoughts: @UziTech |
Sorry for chipping in late on this, I have been quite busy. I wrote a script that I used to import test cases from the spec.json file into md-html fixtures in the following format:
Now this still needs some manual attention as single examples are written to be parsed as a separate document. So link references (that are global to the whole document) often clash, and test cases that tests the behavior if the EOF is encountered should be put in a separate file. I had also rewrote the test runner to parse (the That's what I'd been working on. I suggest you not to take this road: #1129 because it is not scalable IMHO. Everything I've listed above is currently unmergeable on master, but you can at least use the import.js script. /cc @UziTech |
@Feder1co5oave What do you mean by not scalable? Jasmine can be used in the browser as well so it shouldn't be difficult to get it running on browserstack. @davisjam is also using |
Ok, i think I missed that JSON thing!
… |
@Feder1co5oave: My turn to apologize for a late response. I definitely appreciate the concept of the JSON examples. The question is do we generate files (seems like what you're doing) or just loop over them every time we run tests. I would tend toward the creation of files as we may not support every example. Is there a GFM equivalent for the table extensions and whatnot?? |
@UziTech: Will the current test harness run all tests in the Closing and converting to issue to remind myself. |
Marked version: 0.3.17
Might have overcommitted when I said equivalent of 7 a day (also, pardon the off by one error). Stopping for now to re-evaluate approach and level of committment.
Markdown flavor: CommonMark
Description
Time elapsed: 20+ minutes. (20/8 = 2.5 minutes per) This includes coming up with minimal optimizations strategies along the way:
npm test
.Think this is the correct equation for total time:
(625-8)/2.5*60 = 14,808 hours
Considerations and ideas (??):
Recommend holding off on merging for a moment to discuss optimization strategies.
Contributor
Committer
In most cases, this should be a different person than the contributor.