Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM Example 332 #1125

Closed
wants to merge 1 commit into from
Closed

CM Example 332 #1125

wants to merge 1 commit into from

Conversation

joshbruce
Copy link
Member

Marked version: 0.3.17

Markdown flavor: CommonMark

Just realized, I actually don't know which flavor this is. While we say we support CommonMark, I am not explicitly setting the flavor using front matter. GFM is CommonMark with some extensions...anyway, gotta go.

Description

Expectation

<p>a * foo bar*</p>

Result

<p>a*foobar*</p>

What was attempted

a * foo bar*

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@joshbruce
Copy link
Member Author

@styfle: Think we should consider reordering the PR template...

  1. (What I) Attempted
  2. (What I) Expected
  3. (I) Got

@styfle
Copy link
Member

styfle commented Mar 4, 2018

I think what you are describing fits for describing a bug template not a PR. I would expect a PR to fix to a reported bug and just link back to it.

@styfle
Copy link
Member

styfle commented Mar 4, 2018

Also this PR is failing CI

@joshbruce
Copy link
Member Author

joshbruce commented Mar 5, 2018

@styfle: Thanks...I thought so as well but wasn't what I was told.

I got an:

  • As a contributor...
  • As an admin...

Story to explain how we came to this kinda hybrid action.

Let's make a new epic for 0.x - number 1 priority.

@joshbruce
Copy link
Member Author

See #1159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants