Support HTML attributes without quotes (Fix #1141) #1142
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 0.3.17
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown
Description
I modified a regex to match HTML tags to
For example, when matching to
<a href=https://example.com>
,\s[^<=>\/\s]*
matches to attribute name just before=
:href
=[^<>\s]+
matches to=
and attribute value without quotes:=https://example.com
(?:...)
matches only strings starting with=
or\s
. So finally it breaks and matches to the last>
Contributor
Committer
In most cases, this should be a different person than the contributor.