Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetize and add carlos #1149

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Alphabetize and add carlos #1149

merged 2 commits into from
Apr 12, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Mar 21, 2018

@mention the contributor: @carlosvalle

This is a recommendation to:

  • Add a badge
  • Remove a badge

See #1057

If you're the one mentioned in this PR:

  • whether you will accept the badge or not; or,
  • whether you will or will not dispute the recommendation to remove

within 30 days (silence is consent at this point, can't have the pull requests page filled with PRs related to badges forever).

Note: All committers must approve via review before merging, the disapproving committer can simply close the PR.

@styfle
Copy link
Member

styfle commented Apr 11, 2018

Give it another week?

@joshbruce
Copy link
Member Author

@styfle: That's what I'm thinking. The mentioned have 30 days to state their choice. Believe silence = consent to not have the honor.

Tagging @carlosvalle just to make sure he gets fair consideration and warning.

@carlosvalle
Copy link

Looks good to me - Sorry, I didn't know I have to approve this PR.

@joshbruce
Copy link
Member Author

@carlosvalle: No worries. We're still working out the kinks on this process.

@joshbruce joshbruce merged commit e9eca32 into markedjs:master Apr 12, 2018
@joshbruce joshbruce deleted the carlos-marked-mark-maker branch April 12, 2018 15:57
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants