Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show failing test when original tests takes > 1s #1228

Merged
merged 2 commits into from
Apr 17, 2018
Merged

show failing test when original tests takes > 1s #1228

merged 2 commits into from
Apr 17, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Apr 17, 2018

Marked version: 0.3.19

Description

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

test/index.js Outdated
@@ -198,6 +195,11 @@ function testFile(engine, file, filename, index) {
}
}

if (elapsed[0] !== 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a little more clear if you used if (elapsed[0] > 0).

I wish we could use destructuring and do something like

var [ seconds, _ ] = elapsed;
if (seconds > 0) {}
``

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test/index.js Outdated
@@ -198,6 +195,11 @@ function testFile(engine, file, filename, index) {
}
}

if (elapsed[0] !== 0) {
console.log(' failed because it took too long.\n\n passed in %dms', prettyElapsedTime(elapsed));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should console.log be console.error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the other calls are console.error I don't see any reason to change it.

Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@styfle styfle merged commit 6d2568b into markedjs:master Apr 17, 2018
@joshbruce
Copy link
Member

@styfle: You caught me while I was updating the notes. lol

@styfle
Copy link
Member

styfle commented Apr 17, 2018

@joshbruce Oops, did we lose something?

@joshbruce
Copy link
Member

@styfle: There's a slight chance we might have lost something in the Release Notes. I consolidated some, which may have been an area you were adding them to. Double-check??

@styfle
Copy link
Member

styfle commented Apr 17, 2018

@joshbruce They're all there 👍

@UziTech UziTech deleted the show-failing-by-time branch February 19, 2019 20:18
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
show failing test when original tests takes > 1s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants